nano: follow git-for-windows and paint interface elements #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Software distributions should not modify user configured options except when it causes issue with the basic use case. |
The proposed changes do not modify any user configured options. As far as I know, user configured options for nano goes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says: follow git-for-windows and paint interface elements of nano
https://github.com/git-for-windows/git-sdk-64/blob/869fd0088bed870075a3a8e109367c0920625b57/etc/nanorc#L219-L233
Note
I did not use the same colors as git-for-windows to differentiate the MSYS2 shells. The
titlecolorwas set as magenta (resembles MSYS2 icon color), and orange / yellow on other parts to resemble the recommended environment (UCRT64) icon color.Screenshots
Once this PR is merged, a file opened on nano through any MSYS2 shell would look like the following image
Wishes
In my opinion, MSYS2 should go even further enabling the default syntax highlighting files by uncommenting the line 252